Implement backfill querying #1310
Conversation
yeukovichd
requested review from
aLekSer,
calebatwd,
HazWard,
syntxerror and
Laremere
as code owners
|
Attaching the gist of the diff, part of the code where moved into a separate file |
| @@ -162,15 +162,15 @@ func (om *om) MMFConfigHTTP() *pb.FunctionConfig { | |||
| // that parsing bugs can't hide logic bugs. | |||
| const registrationInterval = time.Millisecond * 200 | |||
| const proposalCollectionInterval = time.Millisecond * 200 | |||
| const pendingReleaseTimeout = time.Millisecond * 200 | |||
There was a problem hiding this comment.
Do the backfill tests need a larger timeout? Given that this behavior may impact both backfill / non backfill scenarios - whats the impact of this on the regular e2e tests etc.?
(I see this being used in TestTicketReleaseByTimeout / TestReleaseTickets etc.)
There was a problem hiding this comment.
@yeukovichd addressed this in Slack before:
The reason why TestProposedBackfillUpdate is failing time to time because sometimes it takes a little bit longer than pendingReleaseTimeout (200ms in tests) to create\update backfill after tickets added to pending release in synchroniser.
What this PR does / Why we need it:
PR allows querying and caching backfills.
A take over of #1300 and #1280 also has @Laremere comments.