Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string err comparisons to backfill e2e #1344

Merged
merged 1 commit into from
Jan 20, 2021

Conversation

akremsa
Copy link

@akremsa akremsa commented Jan 20, 2021

What this PR does / Why we need it:
This PR improves tests output in case of a failure.

Before:

        	            	expected: *errors.errorString(&errors.errorString{s:"EOF"})
        	            	actual  : *status.Error(&status.Error{e:(*status.Status)(0xc000b08600)})

After:

        	Error:      	Not equal: 
        	            	expected: "EOF"
        	            	actual  : "qwe"

@aLekSer aLekSer merged commit ad1ca16 into googleforgames:master Jan 20, 2021
@syntxerror syntxerror added this to the v1.2.0 milestone Mar 25, 2021
@syntxerror syntxerror added area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match area/refinement and removed area/developer-experience This issue impacts developer experience when building a Matchmaker using Open Match labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants