Return 404 when deleting ticket/backfill ticket that does not exist #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucy-yuan
requested review from
aLekSer,
calebatwd,
HazWard,
syntxerror,
Laremere and
sawagh
as code owners
|
@lucy-yuan Thanks for the contribution. Branch is out of date at the moment. I'll merge once it is resolved. |
lucy-yuan
force-pushed
the
bug/delete-ticket-response-code
branch
from
0a0fba8
to
1e39c7b
Compare
syntxerror
approved these changes
Feb 16, 2021
syntxerror
added
area/developer-experience
syntxerror
added a commit
that referenced
this pull request
Apr 14, 2021
* Fix minor typos (#1347) * Make tests output readable (#1349) * Fix WatchAssignments causes memory leaks (#1350) * Return 404 when deleting ticket/backfill ticket that does not exist (#1352) * Updating jonfoust username to syntxerror as a code reviewer (#1363) Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> * Update to gRPC Gateway v2 (#1358) * update master * Sentinel fix (#1367) * update master * override sentinel.usePassword to false Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> * Revert "Sentinel fix (#1367)" (#1368) This reverts commit 8b8617f. * fixing config.json * Sentinel fix (2) (#1369) * update master * fixing config.json * add override for sentinel.usePassword * Update go.sum removed leftover from conflict * Release-1.2.0-rc.1 steps and dependency updates * Add backfill scenario to scale tests (#1339) * Implement backfill querying * Update location for stable and incubator charts * Add MMF backfill example * Simplify MMF backfill example * Add backfill scenario to scale tests * Update backfill scenario * Improve backfill scenario Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> Co-authored-by: Alexey <oleksii.kremsa@globant.com> Co-authored-by: yeukovichd <dmitry.yeukovich@globant.com> Co-authored-by: Lucy Yuan <lucy.yuan@unity3d.com> Co-authored-by: Andrew Grundy <andrewgrundy@2k.com>
syntxerror
added a commit
that referenced
this pull request
Apr 30, 2021
* Fix minor typos (#1347) * Make tests output readable (#1349) * Fix WatchAssignments causes memory leaks (#1350) * Return 404 when deleting ticket/backfill ticket that does not exist (#1352) * Updating jonfoust username to syntxerror as a code reviewer (#1363) Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> * Update to gRPC Gateway v2 (#1358) * Sentinel fix (#1367) * update master * override sentinel.usePassword to false Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> * Revert "Sentinel fix (#1367)" (#1368) This reverts commit 8b8617f. * Sentinel fix (2) (#1369) * update master * fixing config.json * add override for sentinel.usePassword * Update go.sum removed leftover from conflict * Add backfill scenario to scale tests (#1339) * Implement backfill querying * Update location for stable and incubator charts * Add MMF backfill example * Simplify MMF backfill example * Add backfill scenario to scale tests * Update backfill scenario * Improve backfill scenario Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> * add mode to profile name for range of game modes (#1375) * changes for release 1.2.0 process Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com> Co-authored-by: Alexey <oleksii.kremsa@globant.com> Co-authored-by: yeukovichd <dmitry.yeukovich@globant.com> Co-authored-by: Lucy Yuan <lucy.yuan@unity3d.com> Co-authored-by: jonfoust <38893532+jonfoust@users.noreply.github.com> Co-authored-by: Andrew Grundy <andrewgrundy@2k.com> Co-authored-by: John Pekcan <johnpekcan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
Delete requests will return 404 instead of 200 when the resource (ticket) is not found. This does not break the concept of idempotency and will align with get requests as well as the frontend swagger configuration.