Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional Redis HA deployment for #41 #48

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

ihrankouski
Copy link
Contributor

This PR provides an alternative to default "single instance Redis" option:

  • Replica set of 3 Redis instances and 3 Sentinels for a failover (Redis Operator must be installed in cluster)
  • Since Redigo doesn't support Sentinel, there's a HAProxy based workaround. Inside the pod, there's a shell script that is monitoring master address (asking Sentinels every second). And if address changes then the script refreshes HAProxy configuration without the restart (writing changes to 'stats socket')

Copy link
Collaborator

@joeholley joeholley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as we discussed in slack. Thanks very much!

@joeholley joeholley merged commit 39ff99b into googleforgames:030wip Dec 26, 2018
@ihrankouski ihrankouski deleted the redis_ha branch January 25, 2019 09:32
@ihrankouski ihrankouski restored the redis_ha branch April 12, 2019 09:36
@ihrankouski ihrankouski deleted the redis_ha branch April 12, 2019 09:36
@Laremere Laremere added this to the v0.3.0 milestone Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants