Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary cloning in Filter trait #72

Closed
iffyio opened this issue Jul 16, 2020 · 1 comment
Closed

Avoid unnecessary cloning in Filter trait #72

iffyio opened this issue Jul 16, 2020 · 1 comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@iffyio
Copy link
Collaborator

iffyio commented Jul 16, 2020

We want to update local_receive_filter method so that we only clone endpoints when we need to.

Originally posted by @iffyio in https://github.com/googleforgames/quilkin/pull/69/files/c9c359a94a10e45c0b603f132917212f41d09880
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 25, 2020
@markmandel
Copy link
Member

This work is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markmandel @iffyio