Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed overlapping keyboard when address2 requests focus #450

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

kikoso
Copy link
Collaborator

@kikoso kikoso commented Nov 29, 2022

The following PR fixes an issue when the keyboard stays active and hides the Submit button after the focus is requested by the second address field.

Screen.Recording.2022-11-29.at.16.40.18.mov
  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #180 馃

@kikoso kikoso added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Nov 29, 2022
@kikoso kikoso requested a review from wangela November 29, 2022 12:30
@wangela wangela merged commit 9237a08 into main Dec 12, 2022
@wangela wangela deleted the fix/fixed-overlapping-keyboard-on-focus branch December 12, 2022 20:52
@wangela
Copy link
Collaborator

wangela commented Dec 12, 2022

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete Address Form sample: soft keyboard covers map
2 participants