Skip to content

Commit

Permalink
chore: Disable flaky test. (#193)
Browse files Browse the repository at this point in the history
* chore: Disable flaky test.

Change-Id: Ida47c6738972178790a6c519fc444c3e405932bf

* Remove pull_request_target

Change-Id: Ic2e00097b7e34d83f06bf57e06a9a8c08a305531
  • Loading branch information
arriolac committed Aug 30, 2022
1 parent 6731a2f commit 24f2015
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 16 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/instrumentation-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ on:
branches-ignore: ['gh-pages']
pull_request:
branches-ignore: ['gh-pages']
pull_request_target:
branches-ignore: ['gh-pages']
workflow_dispatch:

jobs:
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ on:
branches-ignore: ['gh-pages']
pull_request:
branches-ignore: ['gh-pages']
pull_request_target:
branches-ignore: ['gh-pages']
workflow_dispatch:

jobs:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,17 +112,18 @@ class MapInColumnTests {
}
}

@Test
fun testScrollColumn_MapCameraRemainsSame() {
initMap()
// Check that the column scrolls to the last item
composeTestRule.onRoot().performTouchInput { swipeUp() }
composeTestRule.waitForIdle()
composeTestRule.onNodeWithTag("Item 1").assertIsNotDisplayed()

// Check that the map didn't change
startingPosition.assertEquals(cameraPositionState.position.target)
}
// FIXME: https://github.com/googlemaps/android-maps-compose/issues/174
// @Test
// fun testScrollColumn_MapCameraRemainsSame() {
// initMap()
// // Check that the column scrolls to the last item
// composeTestRule.onRoot().performTouchInput { swipeUp() }
// composeTestRule.waitForIdle()
// composeTestRule.onNodeWithTag("Item 1").assertIsNotDisplayed()
//
// // Check that the map didn't change
// startingPosition.assertEquals(cameraPositionState.position.target)
// }

// @Test
// fun testPanMapUp_MapCameraChangesColumnDoesNotScroll() {
Expand All @@ -138,4 +139,4 @@ class MapInColumnTests {
// // Check to make sure column didn't scroll
// composeTestRule.onNodeWithTag("Item 1").assertIsDisplayed()
// }
}
}

0 comments on commit 24f2015

Please sign in to comment.