Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows use of ClusterManager#setAlgorithm #420

Closed
matsudamper opened this issue Oct 4, 2023 · 1 comment · Fixed by #421
Closed

Allows use of ClusterManager#setAlgorithm #420

matsudamper opened this issue Oct 4, 2023 · 1 comment · Fixed by #421
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@matsudamper
Copy link
Contributor

matsudamper commented Oct 4, 2023

Is your feature request related to a problem? Please describe.
In Compose, ClusterManager is hidden internally, so ClusterManager#setAlgorithm cannot be used.

Describe the solution you'd like
Make this available.

Describe alternatives you've considered
I think it can be implemented in the following below ways.

  • Pass the algorithm to Clustering Composable.
    • In the future, when all the functions available in Clustering are implemented, the number of arguments may increase.
  • Add the clusterManagerFactory: () -> ClusterManager<T> argument to Clustering Composable and create it.
    • You can do everything you can do with View.
    • Bad. ClusterManager#renderer has been changed internally, causing confusion for users.
  • Call the Clustering Composable with the argument onCreateClusterManager: (ClusterManager<T>) -> Unit
  • [recommend] create rememberClusterRenderer with ClusterManager as an argument.
    • Currently, clusterContent and clusterItemContent are not used when clusterRenderer is specified. I think this is complicated.
    • Prepare a low-level API using ClusterManager that can do the same thing as the View, and a high-level API.

Additional context
Our app has a large number of pins and we need to use NonHierarchicalViewBasedAlgorithm of ScreenBasedAlgorithm.

@matsudamper matsudamper added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 4, 2023
@kikoso kikoso added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Oct 27, 2023
@googlemaps-bot
Copy link
Contributor

🎉 This issue has been resolved in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. released type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants