feat: Implemented so that ClusterManager#setAlgorithm can be use. #421
Conversation
matsudamper
changed the title
matsudamper
changed the title
|
Hello @matsudamper . I like the idea of having a lean API to pass the ClusterManager and set the algorithm directly. This can be arguably a reasonable use case. However, this PR introduces one issue. You can quickly see it by running the Marker Clustering sample, and see that one marker always remains with the background of the shape from the Clustering. Can you check it out? Thanks! |
|
Even if you branch Clustering with if, the marker remains displayed. This issue may be related. |
|
fixed. Please confirm.
|
| SideEffect { | ||
| if (clusterManager?.renderer != renderer) { | ||
| clusterManager?.renderer = renderer ?: return@SideEffect | ||
| } | ||
| } |
There was a problem hiding this comment.
For the high-level APIs, Processing is performed in Clustering Composable.
For the low-level API, I wondered what to do, but did not include it. Because I may be some inconvenience I'm not aware of.
The test was successful in my environment. I didn't know the cause. |
|
Hi @matsudamper , Do not worry about it, currently the Map Key is not being injected into external contributions. |
|
LGTM |
|
This will also help us customize the algorithm for developing and testing fixes to #380 |
# [4.3.0](v4.2.0...v4.3.0) (2023-11-17) ### Features * expose the ClusterManager to support custom algorithms ([#421](#421)) ([b892e61](b892e61))
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Existing problems
As described in the Issue, we thought it would be less confusing for users to separate the low-level API and the high-level API.
Clustering Composable Function that takes a clusterManager as an argument, memberClusterRenderer and memberClusterManager are implemented and make public.
The existing Clustering Composable Function calls the low-level Clustering Composable Function.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #420 🦕