Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix Street View location in README #345

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

lawm
Copy link
Contributor

@lawm lawm commented Jul 22, 2023

The example given crashes (#265). Changed location to match BasicMapActivity.kt, which works.

@google-cla
Copy link

google-cla bot commented Jul 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kikoso
Copy link
Collaborator

kikoso commented Jul 23, 2023

Hi @lawm ! Thanks for sending this fix.

Would you be so kind and check the CLA status? You would need to get it signed before merging your first PR.

@lawm
Copy link
Contributor Author

lawm commented Jul 23, 2023

Hi @lawm ! Thanks for sending this fix.

Would you be so kind and check the CLA status? You would need to get it signed before merging your first PR.

CLA status is ok

@kikoso
Copy link
Collaborator

kikoso commented Jul 23, 2023

Thanks!

@kikoso
Copy link
Collaborator

kikoso commented Jul 28, 2023

@Lawn, could you rebase from the current main branch and re-committed? We have fixed the problem on the instrumentation test.

The example given crashes. Changed location to match BasicMapActivity.kt, which works.
@wangela
Copy link
Member

wangela commented Jul 28, 2023

Instrumentation test failing due to lack of access to environment secret in the fork. No expected impact on instrumentation tests for this PR editing the README.

@wangela wangela changed the title fix Street View location in README chore(docs): fix Street View location in README Jul 28, 2023
@wangela wangela merged commit e46fdf2 into googlemaps:main Jul 28, 2023
8 of 9 checks passed
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants