feat!: setting the custom location button via sample #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bubenheimer
reviewed
Oct 11, 2023
maps-compose/src/main/java/com/google/maps/android/compose/GoogleMap.kt
Outdated
Show resolved
Hide resolved
kikoso
changed the title
bubenheimer
approved these changes
Oct 13, 2023
maps-compose/src/main/java/com/google/maps/android/compose/GoogleMap.kt
Outdated
Show resolved
Hide resolved
maps-compose/src/main/java/com/google/maps/android/compose/GoogleMap.kt
Outdated
Show resolved
Hide resolved
bubenheimer
approved these changes
Oct 13, 2023
bubenheimer
approved these changes
Oct 13, 2023
|
@vladcioricagoogle , we were discussing this issue before. What do you think of this approach? In general it would keep the API a bit leaner, and require handling the |
|
Decisions we make here will also steer the implementation approach for #339. |
|
@kikoso looks good to me, seems that we still can achieve the required functionality so I don't have anything agains it |
kikoso
force-pushed
the
fix/fixed_issue_with_row_google_map
branch
from
bcddee1
to
8c8a41b
Compare
|
@wangela , re-run the test here, now passing. |
wangela
approved these changes
Oct 25, 2023
googlemaps-bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
# [4.0.0](v3.1.1...v4.0.0) (2023-10-25) * feat!: setting the custom location button via sample (#428) ([cebb6a0](cebb6a0)), closes [#428](#428) ### BREAKING CHANGES * remove `myLocationButton` from `GoogleMap`. Equivalent functionality for customizing a map control is demonstrated in the sample app.
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: this PR moves the custom location to the sample instead of managing it via the GoogleMap.
The following PR fixes an issue when a Modifier was set for GoogleMaps. This PR introduces a custom Modifier for the custom location row in the map, and adds this one only when a custom location has been added.Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #427