Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github issue and pull request templates #302

Merged
merged 1 commit into from Aug 15, 2016

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented Aug 13, 2016

See https://github.com/blog/2111-issue-and-pull-request-templates for how these work with Github. It's similar to how the AOSP issue tracker injects template text when you open a new issue.

I've found that these templates result in better formatted issues and pull requests from outside contributors in projects I've worked on, and also force me to better document bug reports/PRs myself as a maintainer - having the template to drop text into streamlines the process significantly.

If there is anything here you don't want (e.g., squashing commits) or something missing, let me know and I'd be happy to update the PR.

@broady
Copy link
Contributor

broady commented Aug 13, 2016

Well, I think it'd be better to get CLA checking via GitHub status checks.

I'm not sure why that doesn't happen...

I just changed the settings for the repo to enforce squashes (disabling merge commits).

So I don't think the PR template is necessary.

@barbeau
Copy link
Collaborator Author

barbeau commented Aug 13, 2016

Well, I think it'd be better to get CLA checking via GitHub status checks.

Agreed, I'm definitely not advocating that the PR template replaces the CLA bot (I've actually wanted to implement a CLA bot on my own repos, but haven't had the time to pull that together).

I think it would help cut back on some notification chatter, though, because if the contributor fills out the CLA prior to submitting the PR, the bot doesn't have to poke them, and they respond. I'm fine removing the PR template, though - I'll force push another commit shortly with just the issue template.

@barbeau
Copy link
Collaborator Author

barbeau commented Aug 13, 2016

Ok, just force-pushed a new commit with just the issue template.

@broady
Copy link
Contributor

broady commented Aug 13, 2016

CLA bot is now on this repo (added it 20 mins ago :)

@broady
Copy link
Contributor

broady commented Aug 13, 2016

will leave to @stephenmcd to review this.

@stephenmcd stephenmcd merged commit 3a59e22 into googlemaps:master Aug 15, 2016
@barbeau barbeau deleted the issueTemplate branch October 4, 2016 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants