-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(CodeCov): Enable CodeCov. #626
Conversation
One of the Travis builds timed out, so I just restarted it (the rest passed). |
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
=========================================
Coverage ? 18.59%
=========================================
Files ? 71
Lines ? 3980
Branches ? 585
=========================================
Hits ? 740
Misses ? 3206
Partials ? 34 Continue to review full report at Codecov.
|
@@ -96,7 +96,7 @@ install: | |||
- source ~/.install-jdk-travis.sh | |||
|
|||
script: | |||
- if [ "$API" != "NONE" ]; then ./gradlew test check connectedCheck -x lint --stacktrace; fi | |||
- if [ "$API" != "NONE" ]; then ./gradlew test check jacocoTestReport connectedCheck -x lint --stacktrace; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test
executes the JUnit tests we have in the library/src/test
, and connectedCheck
executes the instrumented tests we have in library/src/androidTest
. Do you know if jacocoTestReport
covers the output of both of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misread the CodeCov report and thought that reports weren't being uploaded which is true for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM!
Enabling CodeCov on Travis so that code coverage reports can be generated and evaluated on a per-PR basis.