Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(CodeCov): Enable CodeCov. #626

Merged
merged 1 commit into from
Feb 19, 2020
Merged

build(CodeCov): Enable CodeCov. #626

merged 1 commit into from
Feb 19, 2020

Conversation

arriolac
Copy link
Member

Enabling CodeCov on Travis so that code coverage reports can be generated and evaluated on a per-PR basis.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 19, 2020
@barbeau
Copy link
Collaborator

barbeau commented Feb 19, 2020

One of the Travis builds timed out, so I just restarted it (the rest passed).

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@3ca965f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #626   +/-   ##
=========================================
  Coverage          ?   18.59%           
=========================================
  Files             ?       71           
  Lines             ?     3980           
  Branches          ?      585           
=========================================
  Hits              ?      740           
  Misses            ?     3206           
  Partials          ?       34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca965f...6864136. Read the comment docs.

@@ -96,7 +96,7 @@ install:
- source ~/.install-jdk-travis.sh

script:
- if [ "$API" != "NONE" ]; then ./gradlew test check connectedCheck -x lint --stacktrace; fi
- if [ "$API" != "NONE" ]; then ./gradlew test check jacocoTestReport connectedCheck -x lint --stacktrace; fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test executes the JUnit tests we have in the library/src/test, and connectedCheck executes the instrumented tests we have in library/src/androidTest. Do you know if jacocoTestReport covers the output of both of these?

Copy link
Member Author

@arriolac arriolac Feb 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jacocoTestReport will only evaluate the existence of a test (unit or instrumented test) for a particular set of classes (i.e. classes within the :library module). The actual result of the unit and instrumented tests are currently handled by Travis and not CodeCov

Example CodeCov result:
image

@arriolac
Copy link
Member Author

I misread the CodeCov report and thought that reports weren't being uploaded which is true for master since this change hasn't landed on master yet 😅 That said, no further changes are needed. cc @barbeau

Copy link
Collaborator

@barbeau barbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@arriolac arriolac merged commit 1f8fb34 into master Feb 19, 2020
@arriolac arriolac deleted the chris/codecov branch February 19, 2020 19:34
@arriolac arriolac added this to the 1.0 milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants