Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Copy xhdpi resources into default drawable folder #731

Merged
merged 1 commit into from May 27, 2020
Merged

fix: Copy xhdpi resources into default drawable folder #731

merged 1 commit into from May 27, 2020

Conversation

barbeau
Copy link
Collaborator

@barbeau barbeau commented May 21, 2020

This should avoid Resources$NotFoundException, possibly due to app being distributed as an Android App Bundle.

Fixes #532

@barbeau
fix: Copy xhdpi resources into default drawable folder
2a6208d 
This should avoid Resources$NotFoundException, possibly due to app being distributed as an Android App Bundle.

Fixes #532
@barbeau barbeau requested a review from arriolac May 21, 2020 14:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020 •
edited

Codecov Report

Merging #731 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #731   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files          71       71           
  Lines        4047     4047           
  Branches      606      606           
=======================================
  Hits         1598     1598           
  Misses       2346     2346           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6332c8...2a6208d. Read the comment docs.

@barbeau barbeau merged commit 469ccb7 into master May 27, 2020
@barbeau barbeau deleted the sean/default-drawables branch May 27, 2020 15:07
googlemaps-bot pushed a commit that referenced this pull request May 27, 2020
@semantic-release-bot
chore(release): 1.3.2 [skip ci]
233bfa8 
## [1.3.2](v1.3.1...v1.3.2) (2020-05-27)

### Bug Fixes

* Copy xhdpi resources into default drawable folder ([#731](#731)) ([469ccb7](469ccb7)), closes [#532](#532)
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@arriolac arriolac mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arriolac arriolac arriolac approved these changes

Assignees

@arriolac arriolac

Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal Exception: android.content.res.Resources$NotFoundException: Resource ID
4 participants
@barbeau @googlemaps-bot @arriolac @googlebot