Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove function literal with receiver. #103

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

arriolac
Copy link
Member

@arriolac arriolac commented Mar 9, 2022

Since the change introduced in #43, certain await* extensions do no require function literal with receivers anymore. This PR removes those arguments from those calls as no further configurations can be made to the underlying builder objects.

BREAKING CHANGE: Removes function literal receiver from await
extensions that don't require it.

Change-Id: If646464c26351a41114fb8390734f62f72ed80f9
@arriolac arriolac requested a review from wangela March 9, 2022 23:30
@wangela
Copy link
Member

wangela commented Mar 14, 2022

  1. Will this automatically update the documentation?
  2. I don't see anything in the demo app that needs to be updated, perhaps becase none of the affected await* functions are demonstrated. Please confirm.

@arriolac
Copy link
Member Author

arriolac commented Mar 14, 2022

  1. Will this automatically update the documentation?

Yep. Once this pull request is merged the docs.yml workflow will be kicked off which should create a pull request to update the documentation for places-ktx. There are more automations in place which will automerge the pull request once checks have passed.

  1. I don't see anything in the demo app that needs to be updated, perhaps becase none of the affected await* functions are demonstrated. Please confirm.

Yep! That's correct that the demo app doesn't need to be updated since none of the affected await functions are being used. Perhaps we should update the demo app though to demonstrate one of these functions. I'll file a separate issue for this (edit: I created #105).

@arriolac arriolac merged commit f4f6061 into main Mar 15, 2022
@arriolac arriolac deleted the chris/feat/default_actions branch March 15, 2022 18:43
googlemaps-bot pushed a commit that referenced this pull request Mar 15, 2022
# [2.0.0](v1.0.0...v2.0.0) (2022-03-15)

* feat!: Remove function literal with receiver. (#103) ([f4f6061](f4f6061)), closes [#103](#103)

### BREAKING CHANGES

* Removes function literal receiver from await
extensions that don't require it.

Change-Id: If646464c26351a41114fb8390734f62f72ed80f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants