Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker #299

Merged
merged 8 commits into from
May 12, 2020

Conversation

amuramoto
Copy link
Member

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 馃

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2020
@amuramoto amuramoto changed the title Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker [fix] Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker May 8, 2020
@amuramoto amuramoto changed the title [fix] Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker fix: Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker May 8, 2020
@amuramoto amuramoto requested a review from arriolac May 8, 2020 22:08
Copy link
Member

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

@amuramoto amuramoto merged commit c0789a7 into googlemaps:master May 12, 2020
googlemaps-bot pushed a commit that referenced this pull request May 12, 2020
## [3.1.2](v3.1.1...v3.1.2) (2020-05-12)

### Bug Fixes

* **Publish:** Update pbxproj file reference. ([ff4ad3d](ff4ad3d))
* Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker ([#299](#299)) ([c0789a7](c0789a7))
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 3.1.2 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

farshadmb added a commit to farshadmb/google-maps-ios-utils that referenced this pull request Jul 9, 2020
* upstream-master: (54 commits)
  chore: Update Cartfile (googlemaps#303)
  chore: Add CODEOWNERS file.
  chore(release): 3.1.4 [skip ci]
  fix: Make title and snippet mutable for GMUClusterItem. (googlemaps#302)
  build: Update xcodebuild command.
  chore(release): 3.1.3 [skip ci]
  fix: Fix crash in GMUClusterManager (googlemaps#301)
  build: Update destination value.
  chore(release): 3.1.2 [skip ci]
  fix(Publish): Update pbxproj file reference.
  fix: Fixes broken info windows in clustered markers, and adds support to cluster GMSMarker (googlemaps#299)
  build: Support Carthage (googlemaps#296)
  docs: Add run unit test status badge
  chore: Remove .travis.yml
  build(Publish): Rename publish workflow.
  build(Publish): Setting COCOAPODS_TRUNK_TOKEN env variable.
  build(Publish): Adding publish github action.
  chore(release): 3.1.1 [skip ci]
  fix: Use https://github.com/CocoaPods/Specs.git instead of CDN
  docs: Update CHANGELOG.md
  ...

# Conflicts:
#	Google-Maps-iOS-Utils.podspec
#	XcodeConfig/GMU-Target.common.xcconfig
#	samples/SwiftDemoApp/SwiftDemoApp/GeoJSONViewController.swift
#	workspace/GoogleMapsUtils.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants