Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles case where binary request does not return a response #251

Merged
merged 1 commit into from
Nov 19, 2020
Merged

fix: handles case where binary request does not return a response #251

merged 1 commit into from
Nov 19, 2020

Conversation

mgmcintyre
Copy link
Contributor

Fixes #250 馃

Mirrors error handling approach from getJSON / postJSON in getBinary.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 19, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 19, 2020
@mgmcintyre mgmcintyre changed the title handles case where binary request does not return a response Bug Fixes: handles case where binary request does not return a response Nov 19, 2020
@mgmcintyre mgmcintyre changed the title Bug Fixes: handles case where binary request does not return a response fix: handles case where binary request does not return a response Nov 19, 2020
@mgmcintyre
Copy link
Contributor Author

@googlebot I signed it!

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Nov 19, 2020

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 19, 2020
@jpoehnelt jpoehnelt merged commit 621d707 into googlemaps:master Nov 19, 2020
@jpoehnelt
Copy link
Contributor

thanks!

@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 1.3.1 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

@mgmcintyre mgmcintyre deleted the nil-pointer-metrics-call branch November 19, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nil pointer dereference on failed binary request
4 participants