Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Language to FindPlaceFromTextRequest #254

Merged

Conversation

tekkamanendless
Copy link
Contributor

This adds the Language field to FindPlaceFromTextRequest. For more information, see:
https://developers.google.com/maps/documentation/places/web-service/search

This adds the Language field to FindPlaceFromTextRequest.  For more
information, see:
https://developers.google.com/maps/documentation/places/web-service/search
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2021
@tekkamanendless
Copy link
Contributor Author

My results recently started showing up in Japanese (Wilmington, DE 19805 アメリカ合衆国) instead of English (Wilmington, DE 19805 USA), so I figured that I'd just set the Language property to en to force it. However, Language wasn't in the Go structure for FindPlaceFromTextRequest (but it is there for others), and the spec claims that it should be available, so this adds it. It also appears to solve my Japanese-results problem.

@amuramoto amuramoto assigned jpoehnelt and unassigned amuramoto Mar 29, 2021
@jpoehnelt jpoehnelt changed the title Add Language to FindPlaceFromTextRequest fix: Add Language to FindPlaceFromTextRequest Mar 29, 2021
@jpoehnelt jpoehnelt merged commit 6584713 into googlemaps:master Mar 29, 2021
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tekkamanendless tekkamanendless deleted the add-language-to-findplacefromtext branch March 29, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants