-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the Center point to work with coordinates #131
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@speedwheel can you explain why the tests are failing? I suspect you have changed behavior without updating the test suite to match? |
@domesticmouse I will look into it and fix the tests also. |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
I'm going to commit this as-is, and fix the failing test in a follow up PR. |
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
The static maps was not working when using coordinates instead of location name for the Center point.
I removed the url.QueryEscape for the r.Center which fixes this issue.