-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create specific exception instead of generic Exception #175
Comments
I'm always up for reviewing PRs. Thanks! |
the code fragment refers to the readme. |
I meant in the code.
I tried to do the PR but it bears lots of changes..
|
@lsoares do you see a path toward breaking it up into smaller pieces? |
What if |
I'm going to close this out for now. Please feel free to submit either the uber-PR or a series of smaller PRs. I'm about to break the world by migrating from OkHttp2 to OkHttp3, however... |
Dealing with generic exceptions creates some dangers. I propose that you create a specific exception (or more) like
GeocodingException
or likewise.Otherwise, I may be be preventing runtime exceptions (and also catched exceptions) under "other code" to bubble up...
(I can also do it as PR if you prefer.)
The text was updated successfully, but these errors were encountered: