Make PendingResult#await throw specific Exception #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 9, 2017 21:21
…verb is specified. Before this change, such request ended up NullPointerExceptions.
…lasses, not generic Exception
…ctor so exception is thrown if invalid key is passed or provider for HMAC-SHA1 doesn't exist
…TF-8 According to following doc, UTF-8 support is required for every Java implementation. http://docs.oracle.com/javase/6/docs/api/java/nio/charset/Charset.html
…ptions, rather than generic Exception.
|
Thank you for this cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #175. Currently PendingResult#await() throws generic Exception. This PR refactor so it throws IOException (exception during HTTP communication), InterruptedException (interrupted while waiting response), ApiException (error in API response).