Making tests happy. #100
Merged
Making tests happy. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @markmcd |
| contexts.add(new Object[]{context}); | ||
| } | ||
|
|
||
| if (supportsClientId) { | ||
| if (!(System.getenv("CLIENT_ID") == null | ||
| || System.getenv("CLIENT_SECRET") == null)) { |
There was a problem hiding this comment.
nit: continuation spacing here should be +4
There was a problem hiding this comment.
Do we have a code style import method for IntelliJ?
|
|
| || System.getProperty("client.secret") == null || System.getProperty("client.secret").equals(""))) { | ||
| GeoApiContext context = new GeoApiContext() | ||
| .setEnterpriseCredentials(System.getProperty("client.id"), System.getProperty("client.secret")); | ||
| contexts.add(new Object[]{context}); |
There was a problem hiding this comment.
There must be some way to make this read more nicely. Maybe some local variables?
There was a problem hiding this comment.
I've introduced local vars. What line length limit are we using for this project?
There was a problem hiding this comment.
lg. i think 100-120 is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also trimming whitespace from README.md.