Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build: ResponseBody not imported in OkHttpPendingResult #371

Closed
wants to merge 2 commits into from

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Nov 12, 2017

Looks like #368 broke the build: in the current version, ResponseBody is used but not imported.

When I build from master at commit 6daaa17, I get this build error:

$ ./gradlew build

> Task :compileJava
warning: [options] bootstrap class path not set in conjunction with -source 1.7
/Users/janke/local/repos/google-maps-services-java/build/filtered/src/main/java/com/google/maps/internal/OkHttpPendingResult.java:224: error: cannot find symbol
    try (ResponseBody body = response.body()) {
         ^
  symbol:   class ResponseBody
  location: class OkHttpPendingResult<T,R>
  where T,R are type-variables:
    T extends Object declared in class OkHttpPendingResult
    R extends ApiResponse<T> declared in class OkHttpPendingResult
1 error


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':compileJava'.
> Compilation failed; see the compiler error output for details.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 0s
2 actionable tasks: 2 executed

This PR fixes it by adding the import.

This PR also includes a style fix so the build passes the googleJavaFormat style check.

@apjanke
Copy link
Contributor Author

apjanke commented Nov 12, 2017

Never mind. This was fixed by #370 while I was preparing this PR.

@apjanke apjanke closed this Nov 12, 2017
@apjanke apjanke deleted the fix-build-for-ResponseBody branch November 12, 2017 23:23
@domesticmouse
Copy link
Contributor

Thanks! =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants