Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use comma arrayFormat for place fields #316

Merged
merged 2 commits into from Feb 8, 2020

Conversation

jpoehnelt
Copy link
Contributor

closes #314

Lucky there is only one array format for this request...

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2020
@codecov
Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #316 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #316   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         323    323           
  Branches       83     83           
=====================================
  Hits          323    323
Impacted Files Coverage Δ
src/places/details.ts 100% <100%> (ø) ⬆️
src/places/findplacefromtext.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d52cf6...9694c09. Read the comment docs.

@jpoehnelt jpoehnelt merged commit f061eb7 into master Feb 8, 2020
@jpoehnelt jpoehnelt deleted the fix/array_format_fields branch February 8, 2020 09:32
jpoehnelt pushed a commit that referenced this pull request Feb 8, 2020
## [2.0.2](v2.0.1...v2.0.2) (2020-02-08)

### Bug Fixes

* use comma arrayFormat for fields param ([#316](#316)) ([f061eb7](f061eb7))
BaljeetSinghaw added a commit to BaljeetSinghaw/services-js that referenced this pull request Nov 11, 2022
Smile4192 added a commit to Smile4192/google-maps-service-js that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Places: fields parameter serialization
2 participants