Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add place_id to geocode #413

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

Matgsan
Copy link
Contributor

@Matgsan Matgsan commented Jun 10, 2020

Add place_id param to GeocodeRequest.

Fixes #408 馃

Add place_id param to GeocodeRequest.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #413 into master will decrease coverage by 1.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #413      +/-   ##
===========================================
- Coverage   100.00%   98.94%   -1.06%     
===========================================
  Files           22       22              
  Lines          760      760              
  Branches       124      124              
===========================================
- Hits           760      752       -8     
- Misses           0        8       +8     
Impacted Files Coverage 螖
src/geocode/geocode.ts 100.00% <酶> (酶)
src/distance.ts 84.61% <0.00%> (-15.39%) 猬囷笍
src/elevation.ts 84.61% <0.00%> (-15.39%) 猬囷笍
src/directions.ts 87.50% <0.00%> (-12.50%) 猬囷笍
src/roads/snaptoroads.ts 91.66% <0.00%> (-8.34%) 猬囷笍
src/roads/nearestroads.ts 91.66% <0.00%> (-8.34%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 090141d...aaa61b5. Read the comment docs.

@Matgsan
Copy link
Contributor Author

Matgsan commented Jun 10, 2020

Could not understand why the coverage dropped. If anyone can tell me I can fix it.

@jpoehnelt
Copy link
Contributor

Thanks!

Currently coverage is including some e2e tests which are not run for pull requests.

@jpoehnelt jpoehnelt merged commit f860fd4 into googlemaps:master Jun 12, 2020
@googlemaps-bot
Copy link
Contributor

馃帀 This PR is included in version 3.1.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geocode to accept param "place_id"
4 participants