New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distance matrix departure time unit change from miliseconds to seconds #124
Conversation
departure time changed from miliseconds to seconds
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed CLA |
CLAs look good, thanks! |
spec/e2e/distance-matrix-spec.js
Outdated
@@ -21,7 +21,8 @@ var objectContaining = jasmine.objectContaining; | |||
describe('distance matrix client library', function() { | |||
var googleMaps = require('./service'); | |||
|
|||
var inOneHour = new Date().getTime() + 60 * 60 * 1000; | |||
var now = new Date().getTime(); | |||
var inOneHour = Math.round(now/1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still one hour ahead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh sorry you are right I've corrected it
Every time in this library is in milliseconds while google documentations says following about departure_time and arriavel_time: |
departure time changed from miliseconds to seconds