Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distance matrix departure time unit change from miliseconds to seconds #124

Merged
merged 2 commits into from Jun 15, 2019
Merged

Conversation

monajafi
Copy link
Contributor

departure time changed from miliseconds to seconds

departure time changed from miliseconds to seconds
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@monajafi
Copy link
Contributor Author

I signed CLA

@googlebot
Copy link

CLAs look good, thanks!

@@ -21,7 +21,8 @@ var objectContaining = jasmine.objectContaining;
describe('distance matrix client library', function() {
var googleMaps = require('./service');

var inOneHour = new Date().getTime() + 60 * 60 * 1000;
var now = new Date().getTime();
var inOneHour = Math.round(now/1000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still one hour ahead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry you are right I've corrected it

@monajafi
Copy link
Contributor Author

Every time in this library is in milliseconds while google documentations says following about departure_time and arriavel_time:
departure_time — Specifies the desired time of departure. You can specify the time as an integer in seconds since midnight, January 1, 1970 UTC. Alternatively, you can specify a value of now, which sets the departure time to the current time (correct to the nearest second).
As you see it says time in seconds since january 1 ,1970 not milliseconds . you set milliseconds everywhere in tests not seconds. not just distanceMatrix I see in directions Api too

@amuramoto amuramoto merged commit fead2de into googlemaps:master Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants