Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placesNearby rankby parameter #45

Merged
merged 1 commit into from Oct 13, 2016
Merged

Conversation

dconde7
Copy link

@dconde7 dconde7 commented Oct 12, 2016

Changed ‘rankBy’ parameter to ‘rankby’. Using ‘rankBy’ always returns zero results.

Added test case for nearby places search ranked by distance.

Documentation at https://developers.google.com/maps/documentation/javascript/places should also be updated. Already submitted feedback.

Changed ‘rankBy’ parameter to ‘rankby’. Using ‘rankBy’ always returns zero results.

Added test case for nearby places search ranked by distance.

Documentation at https://developers.google.com/maps/documentation/javascript/places should also be updated. Already submitted feedback.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@dconde7
Copy link
Author

dconde7 commented Oct 12, 2016

I am the commit author and sender of the pull request. Both actions were done using the same name, email address and github account name that is in the CLA.

@stephenmcd
Copy link
Contributor

Thanks a lot!

BTW the docs you linked to are for the JavaScript library which uses rankBy, so those are correct. Web services uses rankby, so your fix for this library is correct.

@stephenmcd stephenmcd merged commit 652ce2e into googlemaps:master Oct 13, 2016
@jsvoid
Copy link

jsvoid commented Oct 19, 2016

Could you please also update the package on npm?

@stephenmcd
Copy link
Contributor

0.3.0 is on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants