Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set base_url default value inside _request() instead of in signature #204

Closed
wants to merge 1 commit into from

Conversation

kerrick-lyft
Copy link
Contributor

@kerrick-lyft kerrick-lyft commented Oct 23, 2017

If an end-user of the library wants to override _DEFAULT_BASE_URL (e.g. in order to use a proxy), this makes it easier. The user can simply run

googlemaps.client._DEFAULT_BASE_URL = 'http://my_proxy_dns'

in their server/script's startup code.

Without this change, the default value for the parameter gets "baked" into the function definition and is harder to change.

(Obviously a module's internal implementation details are subject to change, and this PR doesn't construe a guarantee that overriding _DEFAULT_BASE_URL will continue to work in the future).

If an end-user of the library wants to override _DEFAULT_BASE_URL (e.g. in order to use a proxy), this makes it easier. The user can simply run

```
googlemaps.client._DEFAULT_BASE_URL = 'http://my_proxy_dns'
```

in their server/script's startup code.

Without this change, the default value for the parameter gets "baked" into the function definition and is harder to change.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@kerrick-lyft
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kerrick-lyft
Copy link
Contributor Author

Hey @stephenmcd could I get a review on this?

@kerrick-lyft
Copy link
Contributor Author

It's better to properly expose this as an argument to the Client constructor. Will open a PR for that.

@thatguysimon
Copy link
Contributor

thatguysimon commented May 12, 2020

Hey @kerrick-lyft, I see you didn't create another PR. Did you find another workaround for this? I'm having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants