Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Updated project to better support Android Studio #6

Merged
merged 3 commits into from Apr 28, 2016
Merged

Updated project to better support Android Studio #6

merged 3 commits into from Apr 28, 2016

Conversation

ankurkotwal
Copy link
Contributor

  • Migrated to Android Studio project structure
  • Updated Google Play Services dependency to google-play-services-maps:8.4.0
  • Removed reference to support library
  • Removed references to Eclipse from README

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

4. You should see two projects - "hellomap" and "google-play-services_lib".
5. Ensure both are selected
6. Press "Finish"
4. Press "Ok"

## Add your API key

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section doesn't look right for Android Studio. in the default 'Android' view, the manifest is under 'Application -> manifests'


## Add your API key
1. Navigate to AndroidManifest.xml, under the "hellomap" project.
1. Navigate to the AndroidManifest.xml file
2. Click the "AndroidManifest.xml" tab, next to "Instrumentation", to see the XML view.
Copy link
Contributor

@markmcd markmcd Apr 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line still true?

(originally I meant this in terms of the "instrumentation" tab, but it looks like you've added a custom XML file with the key, so I think this whole block needs an update)

@ankurkotwal
Copy link
Contributor Author

@markmcd @jfschmakeit Have addressed all code review comments. PTAL.

@markmcd
Copy link
Contributor

markmcd commented Apr 27, 2016

LGTM

Merge at will

@jfschmakeit jfschmakeit merged commit 4a83e43 into googlearchive:master Apr 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants