Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types are deployed in incorrect folder #483

Closed
BrodaNoel opened this issue Dec 20, 2021 · 3 comments · Fixed by #484
Closed

Types are deployed in incorrect folder #483

BrodaNoel opened this issue Dec 20, 2021 · 3 comments · Fixed by #484
Labels
released triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@BrodaNoel
Copy link

Double check that you are deploying the types (index.d.ts) inside dist/dist/*, instead of dist/*

pwd
xxxxx/node_modules/@googlemaps/js-api-loader/dist/dist
la
total 32
-rw-r--r--  1 noel  staff   8.7K Oct 26  1985 index.d.ts
-rw-r--r--  1 noel  staff    11B Oct 26  1985 index.test.d.ts
@BrodaNoel BrodaNoel added triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 20, 2021
@BrodaNoel
Copy link
Author

I'm seeing this in some projects:

WARNING in ./node_modules/@googlemaps/js-api-loader/dist/index.esm.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from '/xxxxx/node_modules/@googlemaps/js-api-loader/src/index.ts' file: Error: ENOENT: no such file or directory, open '/xxxxx/node_modules/@googlemaps/js-api-loader/src/index.ts'
 @ ./src/pages/xxxx/index.jsx 40:0-38 427:13-23
 @ ./src/App.jsx 258:9-33
 @ ./src/ErrorHandler.jsx 10:0-24 64:38-41
 @ ./src/index.js 14:0-42 45:50-62

@jpoehnelt
Copy link
Contributor

@BrodaNoel seems there are two index.d.ts being published and one the configs passed rollup missing an override. related to rollup/plugins#1049.

I'll start including the src/ folder in the files array.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.12.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants