Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change dependency on fast-{,deep-}equals. #312

Merged
merged 2 commits into from Apr 28, 2022

Conversation

btelles
Copy link
Contributor

@btelles btelles commented Apr 28, 2022

fast-equals has a jsconformance violation whereby the
compiler cannot guarantee a user will never evaluate
a string as a function.

Thank you for opening a Pull Request!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [Remove dependency on fast-equals聽#311] Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • [#] Code coverage does not decrease (if any source code was changed)
  • [#] Appropriate docs were updated (if necessary)

Fixes #311 馃

fast-equals has a jsconformance violation whereby the
compiler cannot guarantee a user will never evaluate
a string as a function.
@jpoehnelt jpoehnelt changed the title Change dependency on fast-{,deep-}equals. fix: change dependency on fast-{,deep-}equals. Apr 28, 2022
package.json Outdated Show resolved Hide resolved
@jpoehnelt jpoehnelt added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Apr 28, 2022
@jpoehnelt jpoehnelt merged commit c1480e8 into googlemaps:main Apr 28, 2022
github-actions bot pushed a commit that referenced this pull request Apr 28, 2022
### [2.0.6](v2.0.5...v2.0.6) (2022-04-28)

### Bug Fixes

* change dependency on fast-{,deep-}equals. ([#312](#312)) ([c1480e8](c1480e8))
github-actions bot pushed a commit that referenced this pull request Apr 28, 2022
* Change dependency on fast-{,deep-}equals.
fast-equals has a jsconformance violation whereby the
compiler cannot guarantee a user will never evaluate
a string as a function.

Co-authored-by: Justin Poehnelt <jpoehnelt@google.com> c1480e8
@github-actions
Copy link

馃帀 This PR is included in version 2.0.6 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on fast-equals
2 participants