More config change bugs: PurchasesUpdatedListener is stored beyond context lifecycle scope

[SUPERCILEX]

Inside launchBillingFlow, you guys do this:

ResultReceiver chaseResultReceiver =
        new ResultReceiver(mUiThreadHandler) {
            @Override
            protected void onReceiveResult(int responseCode, Bundle resultData) {
                // Here you guys store the BroadcastManager which in turn stores the PurchasesUpdatedListener
                mBroadcastManager.getListener().onPurchasesUpdated(responseCode, purchases);
            }
        };

Then you guys send that stored PurchasesUpdatedListener to the ProxyBillingActivity to be used as a callback. That doesn't work of course if the client context is changed with a rotation for example. So then what happens is the onPurchasesUpdated method gets called on an old context instance which is a memory leak and can cause crashes in the client app.

My proposed solution would be to use the custom action and BroadcastReceiver setup you guys have going. So basically instead of sending that ResultReceiver to the ProxyBillingActivity, you guys would just send a broadcast:

  @Override
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
    super.onActivityResult(requestCode, resultCode, data);
    if (requestCode == REQUEST_CODE) {
        if (resultCode != RESULT_OK || responseCode != BillingResponse.OK) {
            // ...
            LocalBroadcastManager.getInstance(this).sendBroadcast(...)
        }
    }
}

Mirrored on the Google Issue Tracker: https://issuetracker.google.com/issues/63267470.