New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not bump pre-15 versions to 15+ #127
Comments
@jkasten2 thanks for the report, we definitely - and unfortunately - missed this case. You're right if any components specify versions of Google Play Services > 15 everything should start using free floating versions as specified by module POM files. We'll take a look. |
@stewartmiles Thanks for the super quick turn around on implementing this! 👍 |
@jkasten2 don't praise me yet ;) Are you sure it works for your use case? |
@stewartmiles Just tested 1.2.75.0 in my example project and can confirm this scenario is now fixed |
@jkasten2 woo, thanks! |
Issue
In Version 12.x and older of GMS and Firebase versions must match exactly with all modules under these groups. This pre-12 logic works correctly in version 1.2.72.0 of this resolver. However if one plugin uses 15 and another is still requesting version 12 or older than we get a mixture of versions. If one library goes to 15+ we need to bump all to 15+.
Semantic versioning schema the Google library team noted in this blog post for reference on the version 15+ changes;
https://android-developers.googleblog.com/2018/05/announcing-new-sdk-versioning.html
Reproducing Issue
1. Create
*Dependency.xml
filesAssets/PluginA/Editor/PluginADependencies.xml
Assets/PluginB/Editor/PluginBDependencies.xml
Asserts/Plugins/Android
folder.com.google.android.gms.play-services-gcm-15.0.1
andcom.google.android.gms.play-services-games-12.0.1
com.google.android.gms.play-services-*
files should be version 15.0.0 or newer.Additional notes
This library was updated to loosen the version locking on 15+ in commit 0c6493a but it seems it did not account a mixture of below and above / at 15 in the same project.
Also, this should have the same effect for Firebase libraries.
The text was updated successfully, but these errors were encountered: