-
Notifications
You must be signed in to change notification settings - Fork 370
Description
Issue
In Version 12.x and older of GMS and Firebase versions must match exactly with all modules under these groups. This pre-12 logic works correctly in version 1.2.72.0 of this resolver. However if one plugin uses 15 and another is still requesting version 12 or older than we get a mixture of versions. If one library goes to 15+ we need to bump all to 15+.
Semantic versioning schema the Google library team noted in this blog post for reference on the version 15+ changes;
https://android-developers.googleblog.com/2018/05/announcing-new-sdk-versioning.html
Reproducing Issue
1. Create *Dependency.xml
files
- 1A.
Assets/PluginA/Editor/PluginADependencies.xml
<dependencies>
<androidPackages>
<androidPackage spec="com.google.android.gms:play-services-games:12.0.1" />
</androidPackages>
</dependencies>
- 1B.
Assets/PluginB/Editor/PluginBDependencies.xml
<dependencies>
<androidPackages>
<androidPackage spec="com.google.android.gms:play-services-gcm:15.0.1" />
</androidPackages>
</dependencies>
- Import play-services-resolver-1.2.72.0.unitypackage
- File > Build Settings... - Select Android and Press "Switch Platforms"
- Run Assets > Play Services Resolver > Android Resolver > Force Resolve
- Observer the
Asserts/Plugins/Android
folder. - Problem - We have
com.google.android.gms.play-services-gcm-15.0.1
andcom.google.android.gms.play-services-games-12.0.1
- Exepected - All
com.google.android.gms.play-services-*
files should be version 15.0.0 or newer.
Additional notes
This library was updated to loosen the version locking on 15+ in commit 0c6493a but it seems it did not account a mixture of below and above / at 15 in the same project.
Also, this should have the same effect for Firebase libraries.