Mixed Dependency Versions bugs 2.0

[JSC-Sparkling]

@stewartmiles The change previously marked as fixed in #123 (and released as resolver v1.2.75) seems to have broken something that wasn't broken in resolver v1.2.72.

Example project containing the bugs:
MixedDependencyVersionBug_v1.2.75.zip

The example contains the following dependencies:
<androidPackage spec="com.google.android.gms:play-services-ads:8.4+">
<androidPackage spec="com.google.android.gms:play-services-ads:9.+">
<androidPackage spec="com.google.android.gms:play-services-analytics:11.8+">

The resolution actually failed completely with the following error:

Resolution failed

Failed to fetch the following dependencies:
com.google.android.gms:play-services-clearcut:11.8+

After some research (mainly looking at the dependencies listed in mvnrepository.com) I figured out that clearcut was added for ads 9.8 (see: https://mvnrepository.com/artifact/com.google.android.gms/play-services-ads/9.8.0) and removed again later on (somewere in version 11.1+ ; but added again at 15.0.1 but this addition is irrelevant in this particular case, source: https://mvnrepository.com/artifact/com.google.android.gms/play-services-ads/11.8.0).

From your previous replies (in issue 123) I've learned that the resolver simply bumps to the highest version, which would be (looking at the 3 dependencies mentioned above) v11.8 ; which is correct and should indeed be used.
Yet the resolver forgets to actually check the required dependencies for the final version it has chosen to resolve.

What I believe that happens is that it find ads 9.8, looks up the dependencies of ads 9.8 and adds it to a list. Then later decides to has to bump the version to 11.8, without re-evaulating the actual dependencies of ads 11.8 and simply bumping the sub-dependencies (obtained based on 9.8) to 11.8. And then obviously clearcut 11.8 won't exist, because it simply isn't a dependency of ads 11.8 anymore in the first place.

Perhaps it could also have something to do with the fact that 2 version increments occur throughout the resolution process, first from 8.4+ to 9.+ (9.8) and then from 9.+ (9.8) to 11.8+

[JSC-Sparkling]

A similar issue like #127 (not bumping pre-15 to 15+) occurs when a more than 2 different versions of dependencies are required.
For example when having the following dependencies:

com.android.support:support-v4:24.2.0+
com.android.support:support-v4:26.0.2
com.google.android.gms:play-services-ads:12.0.1
com.google.android.gms:play-services-ads-identifier:15.0.1.+
com.google.android.gms:play-services-ads-lite:10.2.1+
com.google.android.gms:play-services-base:15.0.1
com.google.android.gms:play-services-basement:10.2.1+
com.google.android.gms:play-services-basement:11.0.1+
com.google.firebase:firebase-analytics:16.0.1
com.google.firebase:firebase-analytics-unity:5.1.1
com.google.firebase:firebase-app-unity:5.1.1
com.google.firebase:firebase-common:16.0.0
com.google.firebase:firebase-config:16.0.0
com.google.firebase:firebase-config-unity:5.1.1
com.google.firebase:firebase-core:16.0.1

With all those dependencies, the resolution occurs incorrectly and ads:12.0.1 (and other aars too) is added instead of expected 15.0.1.
I believe this might be related to the fact that there are more than 2 (in this particular case 4) different dependencies of play-services-* are mentioned/required.

[Edit]
After some investigation, I've figured out that the order of the dependencies seems to be very important.
We had once specific dependency which we changes from ads:11.+ to ads-identifier:15.0.1 which had caused this incorrect resolution to occur. After reverting that specific dependency back to ads:11.+ the resolution does occur correctly. Because of the naming of our *Dependencies.xml I believe the ads-identifier:15.0.1 was encountered first, then another dependency file adds ads:12.0.1 as dependency, and all its sub dependencies are being resolved at 12.0.1 because the resolver "forgot" (or simply didn't take into account) it had already bumped to 15.0.1 just earlier.

[stewartmiles]

@JSC-Sparkling thanks for the report. I think it's due to

unity-jar-resolver/source/PlayServicesResolver/scripts/download_artifacts.gradle

Line 627 in 49653f1

if (addVersionLockedPackageToSet(packageSpec, versionLockedPackages,

, will need to write a test for this. At the moment it looks like I'm adding transitive dependencies of version locked artifacts to the set to fetch and - as you point out - not removing transitive dependencies when conflicts are found and the version expression is made less restrictive.

[JSC-Sparkling]

@stewartmiles, this bug still persists in v1.2.80; Is there any ETA on when it'll be fixed?

[JSC-Sparkling]

With some more fiddling around I have a hunch that I've narrowed it down to the fact that 9.+ is what actually breaks the resolution process, while it all resolves as expcted when using 9.0+ . It seems that that + cannot be placed just anywhere and as soon as It's located at a position where a number is expected, it goes wrong. .+ and .0+ should probably be considered the same thing.

---

When changing the .+ to .0+, the first problem goes away. But the second issue, where 15+ aars are mixed with lower versions, is still there.

[cometa93]

It's impossible to use JarResolver with it... for example when firebase is using version 16.0.2 then all google play services are tried to be resolved with same version...

[JSC-Sparkling]

@cometa93 The example is flawed, because not all play services have to be 16.0.2 ; they have to be atleast 15+ because from 15+ google has decided to change the versioning to SemVer (see release notes of May 2nd 2018: https://developers.google.com/android/guides/releases#may_2_2018).
Because of this version change, a combination of play services below v15 and above v15 cannot, and should not occur because below v15, every aar has to be the same version (as you've mentioned). Atleast, that's how I understood how it should be working (correct me if I'm wrong).

[dfurmanGS]

Yeah, you got right about an versioning, but the jar resolver is trying to download, version equal like (before v15) and by requiring firebase 16.0.2 it's trying to download the same version for all play-services, which are not existing ( or at least not exists on Maven repository)

[JSC-Sparkling]

@dfurmanGS It only does that if your play service resolver's (PSR) version is too low. The particular bug/issue you're describing has been reported in #127 and fixed in v1.2.75 ; The bug related to mixed version I'm describing in this issue are actually different from what issue #127 describes.

[dfurmanGS]

yup but i did resolve on 1.2.79 and still that happened. It was included in newest Firebase.

[dfurmanGS]

yup but i did resolve on 1.2.79 and still that happened. It was included in newest Firebase.

EDIT:

When i'll have computer nearby, i'll update the plugin from scratch again. And will make sure ok?

[dfurmanGS]

@JSC-Sparkling I have to admit, on second computer everything resolved well. I think I had some garbage or wrong SDK configuration or something... sorry for misleading.

Have a nice day.

[exzizt]

@JSC-Sparkling
@dfurmanGS
@stewartmiles

I believe I'm suffering from a mixed dependency issue as my game crashes with the following error when trying to authorize the user:

08-01 16:59:05.451 14969 14969 E AndroidRuntime: Caused by: java.lang.NoClassDefFoundError: Failed resolution of: Lcom/google/android/gms/common/api/Api$zzf;
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.google.android.gms.auth.api.Auth.(Unknown Source)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.google.games.bridge.TokenFragment.buildClient(TokenFragment.java:382)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.google.games.bridge.TokenFragment.processRequest(TokenFragment.java:279)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.google.games.bridge.TokenFragment.onResume(TokenFragment.java:506)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.Fragment.performResume(Fragment.java:2272)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.FragmentManagerImpl.moveToState(FragmentManager.java:1008)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.FragmentManagerImpl.moveToState(FragmentManager.java:1148)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.BackStackRecord.run(BackStackRecord.java:793)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.FragmentManagerImpl.execPendingActions(FragmentManager.java:1535)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.FragmentManagerImpl$1.run(FragmentManager.java:482)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:739)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:95)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.os.Looper.loop(Looper.java:148)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:5551)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:730)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:620)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: Didn't find class "com.google.android.gms.common.api.Api$zzf" on path: DexPathList[[zip file "/data/app/com.exzizt.Birdie-2/base.apk"],nativeLibraryDirectories=[/data/app/com.exzizt.Birdie-2/lib/arm, /data/app/com.exzizt.Birdie-2/base.apk!/lib/armeabi-v7a, /vendor/lib, /system/lib]]
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:56)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:511)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:469)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: ... 17 more
08-01 16:59:05.451 14969 14969 E AndroidRuntime: Suppressed: java.lang.ClassNotFoundException: com.google.android.gms.common.api.Api$zzf
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.Class.classForName(Native Method)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.BootClassLoader.findClass(ClassLoader.java:781)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.BootClassLoader.loadClass(ClassLoader.java:841)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: at java.lang.ClassLoader.loadClass(ClassLoader.java:504)
08-01 16:59:05.451 14969 14969 E AndroidRuntime: ... 18 more
08-01 16:59:05.451 14969 14969 E AndroidRuntime: Caused by: java.lang.NoClassDefFoundError: Class not found using the boot class loader; no stack trace available

As you can see it seems to not have the required Firebase Authorization files (I bolded the line above).

Plugins:

I retried by importing everything into a fresh project. I'm just using the Firebase Auth, Database, AdMob, and Google Play Games Services packages. I still get the same crash as above.

Edit: I am also using the latest version of the jar resolver (1.2.80).

[JSC-Sparkling]

@exzizt You're correct, it seems that you're also suffering from some form of mixed dependencies bug.
As I've explained in a previous post, mixing 15+ and 15- versions doesn't work, and for some reason the PSR does decide to mix them (which is a bug).
Your Auth is 11.8.0, while other dependencies are 15+ and that combination/mix is incompatible and indeed causes crashes.

[exzizt]

@JSC-Sparkling It is very strange though because none of my packages specify an Auth with version 11.
The packages with their dependency files (defaults) are below:

Firebase

AppDependencies.xml

AuthDependencies.xml

DatabaseDependencies.xml

Google

GoogleMobileAdsDependencies.xml

GooglePlayGamesPluginDependencies.xml

Edit:

GooglePlayGamesPluginDependencies.xml has a comment that says something about how "internal dependencies are resolved at runtime"... This is probably the culprit?