Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle version #401

Closed
wants to merge 1 commit into from
Closed

Update gradle version #401

wants to merge 1 commit into from

Conversation

MaxRev-Dev
Copy link

I had a repro of #384 with

  • Unity 2019.2.x
  • External Dependency Manager 1.2.157
    Updating gradle fixes the problem.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MaxRev-Dev
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chkuang-g
Copy link
Collaborator

Hi @MaxRev-Dev

Sorry I cannot accept this CL. I tried this myself awhile ago and it broke EDM4U unit test. Try this:

./gradlew testDownloadArtifacts

I commented my concerns here.
#384 (comment)

Let me know if you can pass the test and make sure all SDK that is using EDM4U will not break because of the change.

@chkuang-g chkuang-g closed this Sep 18, 2020
@googlesamples googlesamples locked and limited conversation to collaborators Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants