Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code block language type should not be enforced #23

Closed
fonnesbeck opened this issue Aug 13, 2018 · 2 comments
Closed

Code block language type should not be enforced #23

fonnesbeck opened this issue Aug 13, 2018 · 2 comments
Assignees
@sqrrrl
Labels
enhancement

Comments

@fonnesbeck
Copy link

fonnesbeck commented Aug 13, 2018 •
edited

It appears to be impossible to specify a code block without specifying a language. If you do, you get:

Unable to generate slides: Error: Unknown language: ` ` is not registered

It would be great to not have to specify a language, but just have unformatted text. It does not appear that the language types are based on linguist, which is most common here. Is there a list of supported languages?
@asrivas asrivas self-assigned this Aug 15, 2018
@erickoledadevrel erickoledadevrel assigned sqrrrl and unassigned asrivas Aug 28, 2018
@sqrrrl
Copy link
Member

sqrrrl commented Sep 7, 2018

Code mostly handled this already if the new line comes directly after the triple back ticks. Any whitespace after though would cause this. Adding some code to trim the value before checking.

@sqrrrl
Copy link
Member

sqrrrl commented Sep 8, 2018

Trimming fixed in next release (0.4)

@sqrrrl sqrrrl closed this as completed Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sqrrrl sqrrrl

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fonnesbeck @sqrrrl @asrivas @erickoledadevrel