Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you still working on this? #602

Closed
grahamjenson opened this issue Jul 26, 2023 · 2 comments
Closed

Are you still working on this? #602

grahamjenson opened this issue Jul 26, 2023 · 2 comments

Comments

@grahamjenson
Copy link
Contributor

I have some PRs:

  1. Migrating logging to slog and adding a bit more log lines
  2. Writing a client for the library

Should I submit them or just keep my fork going?

@erkie
Copy link
Collaborator

erkie commented Aug 11, 2023

PR's are always welcome.

@erkie erkie closed this as completed Aug 11, 2023
@grahamjenson
Copy link
Contributor Author

@erkie

#607
#608
#609
#610
#611

This is my current progress.

My goal is to create a working stable version 3 socket.io client and server that can imitate and interact with the Javascript Socket.io server. I have the time to do it. Eventually, I will need socket.io version 4 (hopefully easier to implement) but that might not be for a while.

Any help merging these would be appreciated so that my fork doesn't ever stray to far away from the source :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants