feat: allow terminal cmd to be a function #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennypowers
added a commit
to bennypowers/alpha-nvim
that referenced
this pull request
Feb 23, 2023
following on from goolord#185 , this allows users to calculate terminal window options like height and width dynamically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to how
valcan be a function, this lets users define a function that returns the terminal command.Why? Users might want to do expensive FS tasks in order to, say, get a random script and determine its dimensions.
Rather than running these expensive tasks in each start up in the
configfunction, it's better to defer these until alpha actually draws the output