Alternate Dinosaur Pajama Colors

[HatNJacket]

About the PR

Adds 8 (Now down to 4) different dinosaur pajamas to the clothing booth into a new Pajamas category.

Why's this needed?

The original dinosaur costume is cute, but seeing differently colored dinosaurs running around is even cuter. Maybe a clown could get the bananasaur costume and go bananas. Variety is good and more dino costumes sounds like a lot of fun.

Credit to the original dinosaur costume goes to DimWhat from PR #5424

Changelog

(u)KolIsDumb, DeadMan164
(+)Added 4 colors of dinosaur pajamas for purchase at the clothing booth

[ThatFiveGuys]

Im fine with more pajama colors but 8 seperate ones with most of the colors not really even fitting the dinosaur theme seems bloaty

[ghost]

maybe a solution would be adding one or two common colors (red, blue, or whichever seem to fit best), and then adding in black and white dino PJs, that way instead of having a bunch of colors in the booth, people can paint or plate the black or white PJs to be a more specific color

[HatNJacket]

I removed half of the added colors, it's down to Red, Blue, Yellow, White, and the original Green.
Forgot to remove the sprites from the dmi files whoops

[thegrb93]

maybe a solution would be adding one or two common colors (red, blue, or whichever seem to fit best), and then adding in black and white dino PJs, that way instead of having a bunch of colors in the booth, people can paint or plate the black or white PJs to be a more specific color

Check and make sure painting them looks any good or not first. I'd be disappointed you guys made him get rid of colors for crappy painting.

[thegrb93]

The paint/plating looks pretty terrible. Considering the Pajamas category has only the dinosaur pajamas, I don't see any reason not to include the rest of the colors.

[thegrb93]

Maybe brown instead of orange, and tan instead of yellow would be more dinosaur-like? Pink/Purple/Black should stay as is though for obvious reasons.

[zjdtmkhzt]

Maybe in the future we should add a feature where different colors of the same thing do not need to be added to the clothing booth as separate articles, but instead with a color choice UI.

[TobleroneSwordfish]

arbitrary RGB pyjamas, I see no issues with this

[thegrb93]

That'd be pretty cool, but I think we'd need to code arbitrary color clothes first. Outside the scope of this pull request. It would be a good first project for someone though.

[WALPVRGIS]

Looks good to me sprite-wise.

(And yeah, personally I'd be fine with more colour options in the future if the Clothing Booth UI was changed to allow for colour swatches, but that's beyond this PR ahaha)

[ZeWaka]

That'd be pretty cool, but I think we'd need to code arbitrary color clothes first.

the majority of the work for arbitrary color clothes has been done thanks to among us - amongus_clothing / color_mapping_matrix()

[thegrb93]

Could you add back 'yellow orange purple pink black'?

[pali6]

Hmm, I'd add an option to recolor things to the clothing booth but most likely it'll get converted to tgui sooner or later so maybe that should be done instead first.

[HatNJacket]

Should I close the PR then? I don't have the knowhow to make a recolor option for the cloning booth and people seem to not want the jammies.

[pali6]

I'm very much not asking you to add the recolor option. Someone else can do that later.

[thegrb93]

Should I close the PR then? I don't have the knowhow to make a recolor option for the cloning booth and people seem to not want the jammies.

@HatNJacket we do, just please re-add the colors you removed.

[HatNJacket]

Should I close the PR then? I don't have the knowhow to make a recolor option for the cloning booth and people seem to not want the jammies.

@HatNJacket we do, just please re-add the colors you removed.

Other admins have said not to add too many things because it was a bit bloaty so I'm not sure if I should

[thegrb93]

@HatNJacket 'Member' is admin, 'Contributor' isn't. None of the admins here said anything about bloat.

[HatNJacket]

@HatNJacket 'Member' is admin, 'Contributor' isn't. None of the admins here said anything about bloat.

Two members have said that they think it's bloat via reactions

[thegrb93]

@pali6 @ZeWaka can we get a definitive answer on whether we can include 'yellow orange purple pink black'? I think they're good to have until the color picker is done.

[flrsh]

I'd consider more colors bloat. 5 is already a lot.

[ThatFiveGuys]

While i think a better ui would help loads player side, the more things you add, the more things someone touching up on something will need to mess with. If someone wants to rearrange the clothing file, now they need to mess with 8 more clothing, and for what? Color differences are fine but they should be meaningfully different and something people will use. I dont really see whats the difference round to round from someone having a orange dino suit versus a yellow one as theyre practically the same suit, and i dont see the point in having clothing that fills the same niche as other clothing and will also only get used once.

[thegrb93]

@ThatFiveGuys you don't use dino pjs so you obviously don't care for it, but some do. I don't see what you're talking about with 'more things someone touching up on something will need to mess with'.

[ThatFiveGuys]

A lot of those colors just werent that appealing with the dino costume, and i doubt some of them would get used. I think some additional colors are cool, but the pink one just doesnt fit the dino design and doesnt really look good.

Code gets refactored, reorganized, etc often, and if someone needs to refactor clothing code for example, this makes it yet another thing they need to mess with. While this individual contribution is relatively small, when you multiply this by every other clothing contributor adding a lot of different variations for minimal reason, it can add up fast. So its generally just a nice idea to keep things on the slimmer side unless theres a justification for that additional stuff.

[thegrb93]

Whatever, it won't matter when there's a color picker. Keep writing paragraphs, that's still just your own opinion.

[thegrb93]

And fyi, purple and pink are perfect barney/clown colors. Also these are like yoshi's colors so if you have a favorite yoshi, then you'd probably have a favorite dino PJ.

[ThatFiveGuys]

Whatever, it won't matter when there's a color picker. Keep writing paragraphs, that's still just your own opinion.

Im refering to the code side of things, that only changes the player facing side of things. Im not degrading this project as a whole, I like some of these (orange is my favorite), but this is just a general design principle for a long running open source codebase. Youre new to this so dont feel discouraged about it, its a clusterfuck, but its just one of those things to keep in mind.