Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe menu counts too many ghost observers #17218

Closed
goonstation-issuebot opened this issue Dec 4, 2023 · 1 comment
Closed

Observe menu counts too many ghost observers #17218

goonstation-issuebot opened this issue Dec 4, 2023 · 1 comment
Labels
A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Bug A bug that impacts usage of a feature E-Verified This bug has been verified to occur P-Trivial A bug that is extremely trivial, such as a spelling issue

Comments

@goonstation-issuebot
Copy link

Labels

[BUG][TRIVIAL]

Description

The observer counter next to a player's name in the Observe menu counts up, but never goes down even when a player stops observing them.

Steps to reproduce

  1. Observe a round
  2. Click a player's name in the observe menu
  3. Move away to stop observing them
  4. Repeat, and watch as each time the counter next to their name is incremented

Expected Behavior

The counter to be accurate

Additional Information & Screenshots

Most definitely related to the fact that observing ghosts can no longer see a player's UI (which isn't in the changelog so I'm not even sure if that's a change or a bug itself)

Reported by: Arahimine
On server: Goonstation 4 Roleplay: Sylvester
Active test merges: #17092 and #17153
Round log date: 2023-12-04-15-45
Reported on: 2023-12-04 17:04:51
Map: DONUT2
@keywordlabeler keywordlabeler bot added C-Bug A bug that impacts usage of a feature P-Trivial A bug that is extremely trivial, such as a spelling issue labels Dec 4, 2023
@TheTyrant25 TheTyrant25 added A-UI Modifies UI in some way. Automatically applied on a change to tgui/ E-Verified This bug has been verified to occur A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... labels Dec 4, 2023
@TheTyrant25 TheTyrant25 self-assigned this Dec 4, 2023
@TheTyrant25
Copy link
Contributor

seemingly caused by #17151

@TheTyrant25 TheTyrant25 removed their assignment Dec 4, 2023
@pali6 pali6 closed this as completed in b9bbe22 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Respawning Deals with (re)spawning of mobs. Roundstart, latejoin, events... A-UI Modifies UI in some way. Automatically applied on a change to tgui/ C-Bug A bug that impacts usage of a feature E-Verified This bug has been verified to occur P-Trivial A bug that is extremely trivial, such as a spelling issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheTyrant25 @goonstation-issuebot