Merge branch 'release/1.2.2'

goooseman · Aug 8, 2019 · ceac03b · ceac03b
2 parents e78fc06 + 28b82a8
commit ceac03b
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "gettext-utils",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "A set of utils to parse react files and export .po files and import them back",
   "bin": "src/cli.js",
   "main": "src/main.js",

diff --git a/src/utils/__fixtures__/pot.json b/src/utils/__fixtures__/pot.json
@@ -14,6 +14,13 @@
         "msgstr": [
           "Project-Id-Version: gettext-utils 1.1.2\nContent-Type: text/plain; charset=utf-8\nPOT-Creation-Date: Thu Jan 01 2018 00:00:00\nContent-Transfer-Encoding: 8bit\nPlural-Forms: nplurals=2; plural=(n != 1);\n"
         ]
+      },
+      "I don't have my own context, sad...": {
+        "msgid": "I don't have my own context, sad...",
+        "comments": {
+          "reference": "__fixtures__/react-project/src/components/LionessHocComponent.tsx:13"
+        },
+        "msgstr": [""]
       }
     },
     "lion.sound": {

diff --git a/src/utils/arePotsDifferent.ts b/src/utils/arePotsDifferent.ts
@@ -6,8 +6,15 @@ const arePotsDifferent = (
 ): boolean => {
   const newTranslations = { ...newPot.translations };
   const oldTranslations = { ...oldPot.translations };
-  delete newTranslations[""];
-  delete oldTranslations[""];
+
+  // We don't want to compare project's metadata
+  if (newTranslations[""]) {
+    delete newTranslations[""][""];
+  }
+  if (oldTranslations[""]) {
+    delete oldTranslations[""][""];
+  }
+
   try {
     assert.deepStrictEqual(newTranslations, oldTranslations);
   } catch (e) {