Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a rdflib for OpenGraphProtocol and schema.org parsing #97

Open
dlrobertson opened this issue Nov 5, 2018 · 2 comments
Open

Use a rdflib for OpenGraphProtocol and schema.org parsing #97

dlrobertson opened this issue Nov 5, 2018 · 2 comments

Comments

@dlrobertson
Copy link
Contributor

dlrobertson commented Nov 5, 2018

Summary

We be able to use rdflib + rdflib-jsonld as the parsers for the Open Graph Protocol and json-ld schema.org parsing. I have a WIP version of this here.

Pros & Cons

Pros

  • rdflib and rdflib-jsonld are both well maintained libraries.
  • We don't have to write/maintain a parser!
  • Users could access the Graph.

Cons

  • Adding another dependency.
  • In some of my testing, parsing seemed slower.
  • It may not actually simplify things. See the WIP version [here] for examples.
@barrust
Copy link
Collaborator

barrust commented Nov 6, 2018

Would this also help resolve #91?

Would the added dependency restrict access to the library? I.e., would it work in all environments?

@dlrobertson
Copy link
Contributor Author

Would this also help resolve #91?

Yes

would it work in all environments?

I wasn't able to find anything that would indicate otherwise.

After some more testing, I've unfortunately noticed several cases where it doesn't work too well (in my current implementation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants