Added SLL2 layer decoding

[wader]

google/gopacket#933 rebased, regenerated with linter and benchmark commits skipped as i'm not sure they are relevant anymore.

I did a similar PR google/gopacket#1015 sometime ago before i found the one by @dylandreimerink

Done rudimentary manual testing of pcaps. Should some kind of test(s) be added?

[mosajjal]

just converted some of the travis checks into Github ones. gonna close and reopen this to trigger it :)

[wader]

@mosajjal 👍 no worries

[mosajjal]

looks good and doesn't break any existing code. However, it doesn't look like it has any tests. If you have any tests ready to commit that'd be good.

[wader]

There was no tests in the original PR but i can try add something. What you be a good test, parse some minimal sll2 pcap test file?

[mosajjal]

take a look at layers tests like dns. For the sake of consistency we can dump the pcap into bytes for testing purposes. makes it easier imo

[wader]

Added a test case but only included bytes from sll2 and down, looked like other tests only tested from their layer and down.

[mosajjal]

Yep I gather it's the same. looks good to me :) merged

[wader]

Confused, what is this about Go code is not formatted, run 'go fmt github.com/google/stenographer/...? should say go fmt ./...?

A did a fmt and lots of things changed... but i gess you have a PR for this?

[wader]

@mosajjal Aha, good thanks!

[mosajjal]

yep that's an old relic from the Google's repo and Travis CI stuff. hopefully all will get removed in a couple days :)

[wader]

👍 Great, and thanks for picking up the gopacket development again!