Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DHCPv4 header field name hops #21

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

aibor
Copy link
Contributor

@aibor aibor commented Jul 19, 2023

The DHCPv4 header field "HardwareOpts" is misleading. This fields original name by RFC 2131, which just takes it from RFC 951, is "hops". It has never changed meaning and still reflects number of relay agents it passed, as described in RFC 951 section 8.

This commit changes the name of the field "HardwareOpts" to "RelayHops".

The DHCPv4 header field "HardwareOpts" is misleading. This fields
original name by RFC 2131, which just takes it from RFC 951, is "hops".
It has never changed meaning and still reflects number of relay agents
it passed, as described in RFC 951 section 8.

This commit changes the name of the field "HardwareOpts" to "RelayHops".
@mosajjal mosajjal self-assigned this Jul 22, 2023
@mosajjal mosajjal merged commit e45ac2c into gopacket:master Jul 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants