refactor: optimize port map to switch statement #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initializing huge maps as global variables causes a lot of allocations while importing the package (even if the respective feature is never used). Rewrite to use `switch` statements and regen `iana_ports.go`. As observed with `GODEBUG=inittrace=1`: before: ``` init github.com/gopacket/gopacket/layers @0.52 ms, 1.7 ms clock, 395496 bytes, 120 allocs ``` after: ``` init github.com/gopacket/gopacket/layers @1.0 ms, 1.4 ms clock, 27760 bytes, 86 allocs ``` Time can be ignored, but reduction in memory allocation is visible. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 28, 2023
This new fork seems to be more active. The change itself doesn't fix any memory allocation, but I submitted a PR for gopacket/gopacket: gopacket/gopacket#24 Also fix crazy alloc in `tui/components` (this is only relevant for `talosctl`). Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 28, 2023
This new fork seems to be more active. The change itself doesn't fix any memory allocation, but I submitted a PR for gopacket/gopacket: gopacket/gopacket#24 Also fix crazy alloc in `tui/components` (this is only relevant for `talosctl`). Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
Unix4ever
approved these changes
Jul 28, 2023
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 28, 2023
This new fork seems to be more active. The change itself doesn't fix any memory allocation, but I submitted a PR for gopacket/gopacket: gopacket/gopacket#24 Also fix crazy alloc in `tui/components` (this is only relevant for `talosctl`). Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
This was referenced Jul 31, 2023
mosajjal
approved these changes
Sep 10, 2023
smira
added a commit
to smira/talos
that referenced
this pull request
Sep 11, 2023
See * siderolabs#7532 * gopacket/gopacket#24 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing huge maps as global variables causes a lot of allocations while importing the package (even if the respective feature is never used).
Rewrite to use
switchstatements and regeniana_ports.go.As observed with
GODEBUG=inittrace=1:before:
after:
Time can be ignored, but reduction in memory allocation is visible.