pcapgo: add read/write support for Decryption Secrets Block (DSB) #6
Conversation
A Decryption Secrets Block (DSB) stores (session) secrets that enable decryption of packets within the capture file. see https://github.com/pcapng/pcapng/blob/master/draft-tuexen-opsawg-pcapng.md for more info. Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
pcapgo/ngread_dsb_test.go
Outdated
|
|
||
| import ( | ||
| "fmt" | ||
| "github.com/google/gopacket" |
There was a problem hiding this comment.
this needs to change to "github.com/gopacket/gopacket" for the tests to run
Signed-off-by: Steffen Vogel <post@steffenvogel.de>
|
Thanks @mosajjal, I have fixed the imports now. |
|
Codes and tests look good. just need to convert the pcap files used in testing to the actual bytes of each packet to make it consistent with other tests. refer to previous PRs or _test files. |
|
Thanks @mosajjal for the review. Could you elaborate a bit? It seems like also the other tests read-on the pcapng files: gopacket/pcapgo/ngread_test.go Line 69 in ee81b8c |
|
to me the preference is to use byte stream rather than a |
|
I think we are better of with the PCAPng files here as we dont test against packet data but rather against the DSB sections within the file. From my side its ready to merge. |
Prebiously tracked in Google repo as: google/gopacket#1042
Originally submitted by: @cfc4n