feat(chowly-api-client): send order to chowly ref #2778 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 111247423
💛 - Coveralls |
strdr4605
reviewed
May 20, 2020
strdr4605
reviewed
May 20, 2020
KanoniPan
reviewed
May 20, 2020
KanoniPan
reviewed
May 20, 2020
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
from
5d39d00
to
e4363e8
Compare
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
from
e4363e8
to
ec25c14
Compare
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
from
ec25c14
to
e97262e
Compare
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
from
e97262e
to
f79ae23
Compare
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
2 times, most recently
from
07d761a
to
7b8f33f
Compare
|
|
||
| async createOrder(order: ICreateOrder): Promise<Order> { | ||
| const response: AxiosResponse<ICreateOrder> = await this.client.post<ICreateOrder>(`${this.basePrefix}/orders`, order, { | ||
| headers: { 'Content-Type': 'application/json' }, |
There was a problem hiding this comment.
why this method have headers but getMenu is missing them?
There was a problem hiding this comment.
getMenu working without headers, but create Order and get Order not working without headers ( checked in postman).
status: 406
"msg": "Content-Type must be application/json"
| 'special-instructions': string; | ||
| 'menu-choices': string; | ||
| 'menu-choices-hash': IMenuChoice; | ||
| 'customer-name': string | null; |
There was a problem hiding this comment.
maybe 'customer-name'?: string?
There was a problem hiding this comment.
payload schema is string, but in postman is object and special-instructions when response is string , i dont know if is optional.
strdr4605
approved these changes
May 21, 2020
strdr4605
suggested changes
May 21, 2020
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
2 times, most recently
from
ae3989c
to
d8bc27a
Compare
strdr4605
approved these changes
May 21, 2020
ruscon
reviewed
May 21, 2020
tudormd
force-pushed
the
feature/2778-send-order-to-chowly
branch
from
d8bc27a
to
ea4ce7a
Compare
ruscon
approved these changes
May 21, 2020
| phone: string; | ||
| email: string | null; | ||
| address1?: string; | ||
| address2: string | null; |
There was a problem hiding this comment.
address1 is optional but address2 is required?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.