Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopass does not clear the clipboard #1080

Closed
ashfaqfarooqui opened this issue Feb 28, 2019 · 5 comments
Closed

Gopass does not clear the clipboard #1080

ashfaqfarooqui opened this issue Feb 28, 2019 · 5 comments

Comments

@ashfaqfarooqui
Copy link

When I use gopass -c <my-file> the password is copied to the clipboard and should be cleared in 45s. I get a notification that my password is cleared, and using ctrl+v ensures I cannot paste anything. However, if I open my clipboard (copyq) in my case I can still see and access the password.

Steps To Reproduce

  1. Copy the password using gopass -c <my-file>
  2. Wait for 45s to get notified that the password is deleted.
  3. Open clipboard utility (copyq), the password hasn't been cleared.

Environment

  • OS: Manjaro linux, with i3 DM
  • OS version:Linux 42 4.14.102-1-MANJARO Add template feature #1 SMP PREEMPT
  • gopass Version: 1.8.4.2
  • Installation method: Package manager
@dominikschulz
Copy link
Member

Thanks for reporting this issue.

Unfortunately gopass can not, and will not, support any possible clipboard manager out there.
We can't possibly detect any binary listening for clipboard changes. There is some discussion and work on avoiding the clipboard altogether, but if you choose to use the clipboard you need to be careful with such programs.

Feel free to submit a PR to support copyq.

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 31, 2019
@dastier
Copy link

dastier commented Jun 2, 2019

The copyq declares "Ignoring clipboard copied from some windows or containing some text" as one of its features.

How to omit storing text copied from specific windows like a password manager?

although not sure if it will work with cli programs

@stale stale bot removed the wontfix label Jun 2, 2019
@dominikschulz
Copy link
Member

It shouldn't be too hard to implement this, but I'm not going to have time for that anytime soon:
https://copyq.readthedocs.io/en/latest/scripting-api.html#disable

@AnomalRoil
Copy link
Member

@dastier @ashfaqfarooqui Doesn't this allow you to exclude gopass from the application copyq will copy from: https://copyq.readthedocs.io/en/latest/faq.html#how-to-omit-storing-text-copied-from-specific-windows-like-a-password-manager

I'm thinking about closing this, since as @dominikschulz said, we cannot support all the different clipboard that exist and keep reducing our code complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants