Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass adds extra newline? #2623

Closed
sebhoss opened this issue Jul 27, 2023 · 2 comments
Closed

gopass adds extra newline? #2623

sebhoss opened this issue Jul 27, 2023 · 2 comments
Assignees

Comments

@sebhoss
Copy link

sebhoss commented Jul 27, 2023

Summary

Using gopass insert --multiline adds an extra newline at the top of the newly created secret.

Steps To Reproduce

  1. EDITOR=nano gopass insert --multiline some/secret/here
  2. Add the following example content
somerandomstring
---
login: yesplease
  1. gopass show some/secret/here or gopass edit some/secret/here

Expected behavior

There should be no newline added at the top of the file because that breaks gopass --clip.

Environment

  • OS: Fedora
  • OS version: Linux desktop.home.arpa 6.3.12-100.fc37.x86_64 SMP PREEMPT_DYNAMIC Wed Jul 5 20:09:58 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
  • gopass Version: gopass 1.15.5 go1.20.2 linux amd64
  • Installation method: gopass repo

Additional context

I forced EDITOR=nano in the example above to show that this is not happening because of some weird editor. I've tried multiple editors and the problem exists with all of them. Using gopass edit to remove the newline works fine as a workaround.

@AnomalRoil
Copy link
Member

I think this might be the same issue as #2614. (And is correctly pointing at the root cause of said issue.)

@sebhoss
Copy link
Author

sebhoss commented Jul 27, 2023

Oh yeah that's right - sorry did not find that issue before creating this one. Thanks & sorry for the noise

@sebhoss sebhoss closed this as completed Jul 27, 2023
@dominikschulz dominikschulz self-assigned this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants