Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object that starts with a '.' as a dir or file name fails silently #2679

Closed
liljenstolpe opened this issue Oct 18, 2023 · 1 comment
Closed
Labels

Comments

@liljenstolpe
Copy link

Summary

Trying to store a secret with a name (or parent) that starts with a '.' fails silently

Steps To Reproduce

$ echo "this is really, really secret" | gopass insert -a some_mount/.ssh/someSshKey
$ gopass list some_mount some_mount

$

Expected behavior

|
|-- .ssh/someSshKey

Environment

OS: Alpine
OS Version: Linux boxkit.mjolnir 6.5.5-200.fc38.x86_64 #1 SMP PREEMPT_DYNAMIC Sun Sep 24 15:52:44 UTC 2023 x86_64 GNU/Linux
gopass version: gopass 1.15.8 go1.21.3 linux amd64
Installation method: go install

Additional context

This is a silent failure - the command throws no exception, but nothing is stored.

@dominikschulz dominikschulz added the bug Defects label Oct 19, 2023
@dominikschulz
Copy link
Member

I have reproduce this and I believe it's WAI.

  • gopass correctly stores the secret
  • gopass correctly retrieves the secret from the store
  • gopass ls does not show the secret because if contains a hidden folder. I believe this is WAI.

We could maybe add an -a option to show hidden files, but that would come with too many complications so I'd rather not do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants